Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add BitKeep #1177

Merged
merged 3 commits into from Jul 28, 2022
Merged

Conversation

0xfaihai
Copy link
Contributor

Description

Checklist

  • The version field in package.json is incremented following semantic versioning
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works
  • I have run yarn type-check & yarn build to confirm there are not any associated errors
  • This PR passes the Circle CI checks

Copy link
Member

@Adamj1232 Adamj1232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR!!
Small change requested
Please merge in the latest develop branch of web3-onboard
Can you also bump the alpha version within the injected package.json, will become 2.0.15-alpha.3 and after merging in the latest develop branch into your fork

packages/injected/src/types.ts Outdated Show resolved Hide resolved
@Adamj1232 Adamj1232 self-requested a review July 28, 2022 21:16
Copy link
Member

@Adamj1232 Adamj1232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@Adamj1232 Adamj1232 merged commit 31a107f into blocknative:v2-web3-onboard-develop Jul 28, 2022
@Adamj1232 Adamj1232 mentioned this pull request Jul 28, 2022
5 tasks
@aaronbarnardsound aaronbarnardsound mentioned this pull request Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants